Skip to content

gh-112306: Amend 3.7.rst #119160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

Conversation

nineteendo
Copy link
Contributor

@nineteendo nineteendo commented May 18, 2024

@nineteendo
Copy link
Contributor Author

nineteendo commented May 18, 2024

I'm a little confused as to why it hasn't been implemented for 3.13 yet. Did we forget this?

@nineteendo nineteendo marked this pull request as ready for review May 18, 2024 21:42
@hauntsaninja
Copy link
Contributor

I think Larry didn't have time to push it through (and we're now at beta, so will need to wait for 3.14). Jelle and Łukasz have both said they'll ensure it gets done for 3.14.

@nineteendo
Copy link
Contributor Author

nineteendo commented May 19, 2024

OK, I've updated it to 3.14. Doesn't that mean the PEP also needs to be updated? It could be quite confusing to read it has been implemented in 3.13 when it hasn't.

@nineteendo
Copy link
Contributor Author

cc @JelleZijlstra

@JelleZijlstra
Copy link
Member

This isn't entirely accurate, since from __future__ import annotations as originally written definitely will not become the default. However, I'm not entirely clear yet on what the end state will be; just posted about it at https://discuss.python.org/t/pep-649-deferred-evaluation-of-annotations-tentatively-accepted/21331/44.

@nineteendo nineteendo marked this pull request as draft May 19, 2024 12:45
@nineteendo
Copy link
Contributor Author

I'll update this when a decision has been made.

@nineteendo nineteendo marked this pull request as ready for review June 10, 2024 18:12
@nineteendo
Copy link
Contributor Author

nineteendo commented Jun 10, 2024

@JelleZijlstra, does this look better? Or should be the Steering Council be mentioned in the note?
Should we also mention that it still works for the time being?

@JelleZijlstra
Copy link
Member

This wording is not great because the future fate of the future import is undetermined until PEP-749 is accepted, and because what you wrote makes it sound like the behavior of from __future__ import annotations is changing in 3.14 (it isn't). I haven't been able yet to come up with a good, concise alternative though.

@nineteendo
Copy link
Contributor Author

Does this look better? from __future__ import annotations will either continue to work, become a no-op or be removed. It will never become the default.

@nineteendo
Copy link
Contributor Author

I'm closing this. Could you assign yourself to the issue?

@nineteendo nineteendo closed this Jun 21, 2024
@nineteendo nineteendo deleted the amend-whatsnew-3.7 branch June 21, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants