Skip to content

gh-119185: Fix typo in _pyrepl.pager: tempfilepager should be tempfile_pager #118881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 20, 2024
Merged

gh-119185: Fix typo in _pyrepl.pager: tempfilepager should be tempfile_pager #118881

merged 4 commits into from
May 20, 2024

Conversation

Sachaa-Thanasius
Copy link
Contributor

@Sachaa-Thanasius Sachaa-Thanasius commented May 10, 2024 •
edited
Loading

The function name has an underscore. Without this, calling help can cause an exception.

Should be reproducible by calling help() in the repl on Windows. I personally found it by calling it on sysconfig.get_config_var.

Doesn’t seem worthy of a news entry.

@Sachaa-Thanasius
Fix typo in _pyrepl.pager: tempfilepager should be tempfile_pager
403b3e5 
The name with no underscore doesn't exist.
@ghost
Copy link

ghost commented May 10, 2024 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented May 10, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented May 10, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented May 13, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@Eclips4 Eclips4 mentioned this pull request May 19, 2024
Closed
@Eclips4 Eclips4 changed the title Fix typo in _pyrepl.pager: tempfilepager should be tempfile_pager gh-119185: Fix typo in _pyrepl.pager: tempfilepager should be tempfile_pager May 19, 2024
@Eclips4 Eclips4 added the needs backport to 3.13 bugs and security fixes label May 19, 2024
@Eclips4 Eclips4 requested a review from pablogsal May 19, 2024 20:51
@JelleZijlstra JelleZijlstra merged commit 05e1dce into python:main May 20, 2024
@miss-islington-app
Copy link

Thanks @Sachaa-Thanasius for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2024
@Sachaa-Thanasius @miss-islington
pythongh-119185: Fix typo in _pyrepl.pager: tempfilepager should …
3f0adf5 
…be `tempfile_pager` (pythonGH-118881)

Fix typo in `_pyrepl.pager`: `tempfilepager` should be `tempfile_pager`

The name with no underscore doesn't exist.
(cherry picked from commit 05e1dce)

Co-authored-by: Thanos <111999343+Sachaa-Thanasius@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented May 20, 2024

GH-119211 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 20, 2024
@Sachaa-Thanasius Sachaa-Thanasius deleted the patch-1 branch May 20, 2024 14:54
@Sachaa-Thanasius Sachaa-Thanasius restored the patch-1 branch May 20, 2024 14:55
@Sachaa-Thanasius Sachaa-Thanasius deleted the patch-1 branch May 20, 2024 14:55
JelleZijlstra pushed a commit that referenced this pull request May 20, 2024
@miss-islington @Sachaa-Thanasius
[3.13] gh-119185: Fix typo in _pyrepl.pager: tempfilepager should…
a52ed7e 
… be `tempfile_pager` (GH-118881) (#119211)

Fix typo in `_pyrepl.pager`: `tempfilepager` should be `tempfile_pager`

The name with no underscore doesn't exist.
(cherry picked from commit 05e1dce)

Co-authored-by: Thanos <111999343+Sachaa-Thanasius@users.noreply.github.com>
@ambv ambv added the topic-repl Related to the interactive shell label May 23, 2024
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
@Eclips4 Eclips4 mentioned this pull request Jun 8, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@Sachaa-Thanasius @estyxx
pythongh-119185: Fix typo in _pyrepl.pager: tempfilepager should …
b5f66ed 
…be `tempfile_pager` (python#118881)

Fix typo in `_pyrepl.pager`: `tempfilepager` should be `tempfile_pager`

The name with no underscore doesn't exist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eclips4 Eclips4 Eclips4 approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Assignees
No one assigned
Labels
skip news topic-repl Related to the interactive shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sachaa-Thanasius @Eclips4 @ambv @JelleZijlstra