gh-117657: Quiet erroneous TSAN reports of data races in _PySeqLock
#117955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSAN reports a couple of data races between the compare/exchange in
`_PySeqLock_LockWrite` and the non-atomic loads in `_PySeqLock_{Abandon,Unlock}Write`.
This is another instance of TSAN incorrectly modeling failed compare/exchange
as a write instead of a load.
|
All commit authors signed the Contributor License Agreement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSAN reports a couple of data races between the compare/exchange in
_PySeqLock_LockWrite:cpython/Python/lock.c
Line 483 in a23fa33
and the non-atomic loads in
_PySeqLock_AbandonWrite(example race):cpython/Python/lock.c
Lines 493 to 495 in a23fa33
and
_PySeqLock_UnlockWrite(example race):cpython/Python/lock.c
Lines 500 to 502 in a23fa33
This is another instance of TSAN incorrectly modeling failed compare/exchange as a write instead of a load.