Skip to content

Conversation

mhsmith
Copy link
Member

@mhsmith mhsmith commented Mar 27, 2024

This PR fixes various Android test issues which I've discovered over the last few weeks.

Comment on lines +2696 to 2700
@unittest.skipIf(
sys.platform.startswith(("freebsd", "wasi"))
or (sys.platform == "android" and platform.machine() == "x86_64"),
f"this platform doesn't implement IEE 754-2008 properly")
def test_fma_zero_result(self):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See discussion at #116667 (comment).

@mhsmith
Copy link
Member Author

mhsmith commented Apr 4, 2024

@erlend-aasland: Are you able to review this PR? It's a continuation of the previous Android test updates from #115918.

Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some nits. BTW, last time I checked, the sys.platform.startswith idiom was still recommended practice. I'd prefer if we could follow that.

# The Android testbed redirects the native stdout to a pipe,
# which returns a different error code.
known_errnos.append(errno.EACCES)
if (sys.platform == "win32") or (e.errno in known_errnos):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parentheses are not needed.

@mhsmith
Copy link
Member Author

mhsmith commented Apr 5, 2024

The parentheses are not needed.

Fixed.

last time I checked, the sys.platform.startswith idiom was still recommended practice

I actually updated the sys.platform documentation in #116215 (comment) to limit this recommendation to FreeBSD. Ever since Python 3.3, all other PEP 11-supported platforms have returned a fixed string without a version number.

@erlend-aasland
Copy link
Contributor

@mhsmith, thanks for the heads-up, I missed that docs update (and I've must have looked at the 3.12 docs). Perhaps we should consider backporting that doc patch.

@erlend-aasland erlend-aasland enabled auto-merge (squash) April 5, 2024 20:54
@erlend-aasland erlend-aasland merged commit 1d3225a into python:main Apr 5, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
- re-enable test_fcntl_64_bit on Linux aarch64, but disable it on all
  Android ABIs
- use support.setswitchinterval in all relevant tests
- skip test_fma_zero_result on Android x86_64
- accept EACCES when calling os.get_terminal_size on Android
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants