Skip to content

gh-116386: Fix format string "%ld" warning in _xxinterpqueuesmodule #116387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2024
Merged

gh-116386: Fix format string "%ld" warning in _xxinterpqueuesmodule #116387

merged 2 commits into from
Mar 7, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Mar 5, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Mar 5, 2024
Closed
@AlexWaygood AlexWaygood mentioned this pull request Mar 5, 2024
Merged
gvanrossum
gvanrossum approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No warnings on macOS.

serhiy-storchaka
serhiy-storchaka reviewed Mar 6, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would not be more natural to use the %zd format string?

And this looks like a completely different issue than the originally reported one.

@ericsnowcurrently
Copy link
Member

Would not be more natural to use the %zd format string?

Yeah, that was a copy-paste failure on my part. I shouldn't have used PRId64 for _queue.count since it is Py_ssize_t, not int64_t. Using %zd sounds right.

And this looks like a completely different issue than the originally reported one.

This is a fix for my fix (gh-116369) for that originally reported issue.

ericsnowcurrently
ericsnowcurrently requested changes Mar 6, 2024
View reviewed changes
@bedevere-app
Copy link

bedevere-app bot commented Mar 6, 2024

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

ericsnowcurrently
ericsnowcurrently approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sobolevn sobolevn merged commit 40b79ef into python:main Mar 7, 2024
@sobolevn
Copy link
Member Author

sobolevn commented Mar 7, 2024

Thanks for the help and reviews!

@ericsnowcurrently
Copy link
Member

Thanks for fixing this. 😄

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@sobolevn @adorilson
pythongh-116386: Fix format string "%ld" warning in `_xxinterpqueuesm…
014060f 
…odule` (python#116387)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@sobolevn @diegorusso
pythongh-116386: Fix format string "%ld" warning in `_xxinterpqueuesm…
e81040f 
…odule` (python#116387)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sobolevn @ericsnowcurrently @gvanrossum @serhiy-storchaka