Skip to content

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jan 26, 2024

(cherry picked from commit 01d970c)

Co-authored-by: Nikita Sobolev mail@sobolevn.me
Co-authored-by: Hugo van Kemenade 1324225+hugovk@users.noreply.github.com


📚 Documentation preview 📚: https://cpython-previews--114584.org.readthedocs.build/

…4546)

(cherry picked from commit 01d970c)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@hugovk
Copy link
Member

hugovk commented Jan 26, 2024

@sobolevn Please could you check the error?

Error: must not contain warnings:

Doc/c-api/object.rst
  291: c:identifier reference target not found: Py_hash_t
  303: c:identifier reference target not found: Py_hash_t

Ideally to fix the warnings, but if it's not trivial, for backport branches I think it would be okay to put that file back in .nitignore.

@sobolevn
Copy link
Member

Will do

@sobolevn
Copy link
Member

sobolevn commented Feb 4, 2024

Done! 👍

@hugovk hugovk merged commit cf2ecbc into python:3.12 Feb 4, 2024
@hugovk
Copy link
Member

hugovk commented Feb 4, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants