Skip to content

Add CODEOWNERS for dbm #114555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Add CODEOWNERS for dbm #114555

merged 2 commits into from
Jan 25, 2024

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Jan 25, 2024

Since there are no code owners for gdbm and ndbm module, I am adding codeowners who are familiar with codebase and possible to review related changes.

@@ -42,6 +42,9 @@ Lib/test/test_type_*.py @JelleZijlstra
Lib/test/test_capi/test_misc.py @markshannon @gvanrossum
Tools/c-analyzer/ @ericsnowcurrently

# dbms
**/*dbm* @corona10 @erlend-aasland @serhiy-storchaka
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order is just alphabetical ordered.

Copy link
Member Author

@corona10 corona10 Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know if you want to be the most preferred backend. ;)

@erlend-aasland erlend-aasland changed the title no-issue: Update CODEOWNERS for dbm variant modules Add CODEOWNERS for dbm Jan 25, 2024
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me!

@corona10
Copy link
Member Author

Wait @serhiy-storchaka too :)

@corona10 corona10 merged commit 841eacd into python:main Jan 25, 2024
@corona10 corona10 deleted the dbm_codeowner branch January 25, 2024 20:49
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants