Skip to content

gh-113360: Fix doctest failure when __test__ is set to falsy value #113389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

gh-113360: Fix doctest failure when __test__ is set to falsy value #113389

wants to merge 2 commits into from

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Dec 22, 2023 •
edited by bedevere-app bot
Loading

Refs #112109

Thanks a lot for the detailed analysis!

@bedevere-app bedevere-app bot mentioned this pull request Dec 22, 2023
Open
serhiy-storchaka
serhiy-storchaka reviewed Dec 22, 2023
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh. I wrote exactly same changes. But now I think that perhaps fixing the documentation is more correct, since this feature did not work since 2.4.

@serhiy-storchaka
Copy link
Member

It was fixed in other way, by changing the outdated documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sobolevn @serhiy-storchaka