gh-56634: Gettext: raise descriptive error on empty plural-forms value #112895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a2515c9 to
17baf50
Compare
17baf50 to
e38c34c
Compare
e38c34c to
e148f83
Compare
michalbon
approved these changes
Feb 14, 2024
| try: | ||
| plural = v[1].split('plural=')[1] | ||
| except IndexError as e: | ||
| raise ValueError('invalid plural forms syntax') from e |
There was a problem hiding this comment.
from e is not needed, that index error does not add useful information. It is just an implementation detail (we could use the length checks instead, or regular expressions). Use from None instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raising
ValueErrorwith descriptive error message. It handles empty Plural-Forms like"Plural-Forms: \n"(original downstream bug, and fix) but also lack ofplural=keyword, like"Plural-Forms: nplurals=4;\n". In the #56634 ignoring the incorrect syntax was being discussed, as well as issuing warnings. The implementation here is following the suggestion of @serhiy-storchaka of raising an error instead.