Skip to content

gh-112243: Don't include comments in f-string debug expressions #112284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 20, 2023
Merged

gh-112243: Don't include comments in f-string debug expressions #112284

merged 2 commits into from
Nov 20, 2023

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Nov 20, 2023 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 20, 2023
Closed
lysnikolaou
lysnikolaou reviewed Nov 20, 2023
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments. Also, the lint job fails.

@pablogsal
Copy link
Member Author

@lysnikolaou fixed!

lysnikolaou
lysnikolaou approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks good!

@pablogsal pablogsal merged commit d59feb5 into python:main Nov 20, 2023
@pablogsal pablogsal deleted the fstrings_debug branch November 20, 2023 15:18
@bedevere-app
Copy link

bedevere-app bot commented Nov 20, 2023

GH-112285 is a backport of this pull request to the 3.12 branch.

pablogsal added a commit to pablogsal/cpython that referenced this pull request Nov 20, 2023
@pablogsal
[3.12] pythongh-112243: Don't include comments in f-string debug expr…
de4f091 
…essions (pythonGH-112284)

(cherry picked from commit d59feb5)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Nov 20, 2023
@pablogsal
[3.12] gh-112243: Don't include comments in f-string debug expressions (
7e70e2e 
GH-112284) (#112285)

(cherry picked from commit d59feb5)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@pablogsal @aisk
pythongh-112243: Don't include comments in f-string debug expressions (…
cd41ab6 
…python#112284)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@pablogsal @Glyphack
pythongh-112243: Don't include comments in f-string debug expressions (…
25649f7 
…python#112284)
@lysnikolaou lysnikolaou mentioned this pull request Jun 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablogsal @lysnikolaou