Skip to content

[3.11] gh-111942: Fix crashes in TextIOWrapper.reconfigure() (GH-111976) #112059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 15, 2023
Merged

[3.11] gh-111942: Fix crashes in TextIOWrapper.reconfigure() (GH-111976) #112059

merged 2 commits into from
Nov 15, 2023

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 14, 2023 •
edited by bedevere-app bot
Loading

  • Fix crash when encoding is not string or None.
  • Fix crash when both line_buffering and write_through raise exception
    when converted ti int.
  • Add a number of tests for constructor and reconfigure() method
    with invalid arguments.
    (cherry picked from commit ee06fff)

Co-authored-by: Serhiy Storchaka storchaka@gmail.com

@serhiy-storchaka @miss-islington
pythongh-111942: Fix crashes in TextIOWrapper.reconfigure() (pythonGH…
c4fc137 
…-111976)

* Fix crash when encoding is not string or None.
* Fix crash when both line_buffering and write_through raise exception
  when converted ti int.
* Add a number of tests for constructor and reconfigure() method
  with invalid arguments.
(cherry picked from commit ee06fff)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This was referenced Nov 14, 2023
Closed
Merged
@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) November 14, 2023 15:39
@vstinner
Copy link
Member

test_io failed on Address Sanitizer job:

ERROR: test_constructor (test.test_io.CTextIOWrapperTest.test_constructor)
----------------------------------------------------------------------
UnicodeEncodeError: 'utf-8' codec can't encode character '\udcfe' in position 0: surrogates not allowed

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/test/test_io.py", line 2631, in test_constructor
    t.__init__(b, encoding="utf-8", errors='\udcfe')
SystemError: <method 'readable' of '_io.BytesIO' objects> returned a result with an exception set

This PR should be backport to 3.11 with its fix. I will wait until #112089 is merged into 3.12.

@vstinner @serhiy-storchaka
[3.12] pythongh-111942: Fix SystemError in the TextIOWrapper construc…
52cafc8 
…tor (pythonGH-112061) (pythonGH-112089)

In non-debug more the check for the "errors" argument is skipped,
and then PyUnicode_AsUTF8() can fail, but its result was not checked.

Co-authored-by: Victor Stinner <vstinner@python.org>
(cherry picked from commit 9302f05)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka merged commit e2421a3 into python:3.11 Nov 15, 2023
@JelleZijlstra JelleZijlstra mentioned this pull request Apr 22, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miss-islington @vstinner @serhiy-storchaka