Skip to content

[3.11] gh-108303: Move all certificates to Lib/test/certdata/ (GH-109489) #109683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[3.11] gh-108303: Move all certificates to Lib/test/certdata/ (GH-109489) #109683

wants to merge 1 commit into from

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 21, 2023 •
edited by bedevere-app bot
Loading

(cherry picked from commit e57ecf6)

Co-authored-by: Nikita Sobolev mail@sobolevn.me

@sobolevn @miss-islington
pythongh-108303: Move all certificates to Lib/test/certdata/ (pytho…
7e99261 
…nGH-109489)

(cherry picked from commit e57ecf6)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@miss-islington miss-islington requested review from a team, vsajip, 1st1 and asvetlov as code owners September 21, 2023 19:05
This was referenced Sep 21, 2023
Closed
Merged
@vstinner vstinner enabled auto-merge (squash) September 21, 2023 19:06
@vstinner
Copy link
Member

@sobolevn: Oh, there is now a conflict on this backport.

@vstinner
Copy link
Member

vstinner commented Oct 4, 2023

All CI tests on test_nntplib. I clicked on re-run failed tests.

@vstinner
Copy link
Member

vstinner commented Oct 4, 2023

@sobolevn: Oh, there is now a merge conflict. Maybe this change should be backported manually. Can you create a PR for Python 3.11?

The Python 3.12 backport doesn't seem to be affected: PR #109682.

@vstinner
Copy link
Member

I created PR #110646 which includes @sobolevn's fix for test_nntplib.

@vstinner vstinner closed this Oct 10, 2023
auto-merge was automatically disabled October 10, 2023 20:39

Pull request was closed

@miss-islington miss-islington deleted the backport-e57ecf6-3.11 branch October 10, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
awaiting review skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miss-islington @vstinner @sobolevn