gh-91051: fix type watcher test to be robust to existing watcher #107989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itamaro
approved these changes
Aug 16, 2023
|
Thanks @carljm for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
GH-108053 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 16, 2023
pythonGH-107989) (cherry picked from commit fce93c8) Co-authored-by: Carl Meyer <carl@oddbird.net>
Yhg1s
pushed a commit
that referenced
this pull request
Aug 16, 2023
facebook-github-bot
pushed a commit
to facebookincubator/cinder
that referenced
this pull request
Aug 17, 2023
Summary: Use type watchers instead of direct calls for handling type modifications in JIT and shadowcode. Also backport python/cpython#107989 so the type watchers tests are resilient to there already being a type watcher installed. Reviewed By: alexmalyshev Differential Revision: D48340200 fbshipit-source-id: 25798b824bc231bd68f8ec7c4c81bb2fa84e3914
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more case of a watcher test spuriously failing because a watcher is already installed. I think this should be the last one.