Skip to content

gh-104146: Argument clinic: remove dead code highlighted by the vulture tool #107632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 4, 2023
Merged

gh-104146: Argument clinic: remove dead code highlighted by the vulture tool #107632

merged 2 commits into from
Aug 4, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Aug 4, 2023 •
edited by bedevere-bot
Loading

(We definitely shouldn't run vulture on clinic.py in CI -- it has a ton of false positives.)

@bedevere-bot bedevere-bot mentioned this pull request Aug 4, 2023
Closed
erlend-aasland
erlend-aasland reviewed Aug 4, 2023
View reviewed changes
erlend-aasland
erlend-aasland approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood AlexWaygood enabled auto-merge (squash) August 4, 2023 14:30
@AlexWaygood AlexWaygood merged commit 407d7fd into python:main Aug 4, 2023
@AlexWaygood AlexWaygood deleted the clinic-vulture branch August 4, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexWaygood @erlend-aasland @bedevere-bot