[3.11] gh-87474: Fix file descriptor leaks in subprocess.Popen (GH-96351) #104563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GH-96351) This fixes several ways file descriptors could be leaked from `subprocess.Popen` constructor during error conditions by opening them later and using a context manager "fds to close" registration scheme to ensure they get closed before returning. --------- (cherry picked from commit 3a4c44b) Co-authored-by: cptpcrd <31829097+cptpcrd@users.noreply.github.com> Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>
This was referenced May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes several ways file descriptors could be leaked from
subprocess.Popenconstructor during error conditions by opening them later and using a context manager "fds to close" registration scheme to ensure they get closed before returning.(cherry picked from commit 3a4c44b)
Co-authored-by: cptpcrd 31829097+cptpcrd@users.noreply.github.com
Co-authored-by: Gregory P. Smith [Google] greg@krypto.org