Skip to content

[3.11] GH-103472: close response in HTTPConnection._tunnel (GH-103473) #104077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2023
Merged

[3.11] GH-103472: close response in HTTPConnection._tunnel (GH-103473) #104077

merged 1 commit into from
May 2, 2023

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 2, 2023 •
edited by bedevere-bot
Loading

Avoid a potential ResourceWarning in http.client.HTTPConnection
by closing the proxy / tunnel's CONNECT response explicitly.

(cherry picked from commit 9de0cf2)

Co-authored-by: Thomas Grainger tagrain@gmail.com
Co-authored-by: Gregory P. Smith greg@krypto.org

@graingert @gpshead @miss-islington
pythonGH-103472: close response in HTTPConnection._tunnel (pythonGH-1…
8f1ce8f 
…03473)

Avoid a potential `ResourceWarning` in `http.client.HTTPConnection`
by closing the proxy / tunnel's CONNECT response explicitly.

---------

(cherry picked from commit 9de0cf2)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
This was referenced May 2, 2023
Closed
Merged
@gpshead gpshead merged commit 0d40264 into python:3.11 May 2, 2023
@miss-islington miss-islington deleted the backport-9de0cf2-3.11 branch May 2, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miss-islington @gpshead @bedevere-bot @graingert