gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives in tkinter module #102319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ternatives in tkinter module
06c073a to
e68fa8b
Compare
markshannon
reviewed
Feb 28, 2023
| @@ -321,8 +321,6 @@ static PyObject *Tkinter_TclError; | |||
| static int quitMainLoop = 0; | |||
| static int errorInCmd = 0; | |||
| static PyObject *excInCmd; | |||
| static PyObject *valInCmd; | |||
There was a problem hiding this comment.
These were unused before this PR?
There was a problem hiding this comment.
They were used in a couple of Restore() calls, scroll down.
markshannon
approved these changes
Feb 28, 2023
|
I have not followed on these new APIs, but I have no problem trusting you @iritkatriel and @markshannon :-) |
erlend-aasland
added a commit
to erlend-aasland/cpython
that referenced
this pull request
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type and traceback are redundant now.