gh-102179: Fix os.dup2() error reporting for negative fds #102180

izbyshev · 2023-02-23T15:14:55Z

A remnant of old code manually checks the sign of fds, but doesn't set errno before raising OSError:

>>> os.dup2(-1, 0)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  OSError: [Errno 0] Error

Remove the manual check altogether: the C library functions used to implement os.dup2() check fd validity anyway.

Issue: os.dup2() raises wrong OSError for negative fds #102179

A remnant of old code manually checks the sign of fds, but doesn't set errno before raising OSError: ``` >>> os.dup2(-1, 0) Traceback (most recent call last): File "<stdin>", line 1, in <module> OSError: [Errno 0] Error ``` Remove the manual check altogether: the C library functions used to implement os.dup2() check fd validity anyway.

Misc/NEWS.d/next/Library/2023-02-23-15-06-01.gh-issue-102179.P6KQ4c.rst

…6KQ4c.rst

bedevere-bot · 2023-03-03T17:41:40Z

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 01df936 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

kumaraditya303 · 2023-03-04T06:56:51Z

Remove the manual check altogether: the C library functions used to implement os.dup2() check fd validity anyway.

@izbyshev Looks like on wasm this check is not implemented. https://buildbot.python.org/all/#/builders/1060/builds/378/steps/10/logs/stdio

izbyshev · 2023-03-04T08:55:46Z

@izbyshev Looks like on wasm this check is not implemented. https://buildbot.python.org/all/#/builders/1060/builds/378/steps/10/logs/stdio

@kumaraditya303 That's interesting. It seems OSError is raised with E2BIG (1) instead of EBADF (8), which doesn't make sense to me. I'm not familar with WASI, but will take a look.

izbyshev · 2023-03-04T14:01:16Z

@kumaraditya303 I've described the situation with Emscripten in #102179 (comment).

kumaraditya303 · 2023-03-04T14:23:11Z

I've described the situation with Emscripten in #102179 (comment).

Okay, thanks for investigating this!

miss-islington · 2023-03-04T14:24:12Z

Thanks @izbyshev for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington · 2023-03-04T14:24:14Z

Sorry @izbyshev and @kumaraditya303, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker c2bd55d26f8eb2850eb9f9026b5d7f0ed1420b65 3.11

bedevere-bot · 2023-03-04T14:24:38Z

GH-102419 is a backport of this pull request to the 3.10 branch.

…onGH-102180) (cherry picked from commit c2bd55d) Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>

miss-islington · 2023-03-04T14:25:03Z

Thanks @izbyshev for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

…onGH-102180) (cherry picked from commit c2bd55d) Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>

bedevere-bot · 2023-03-04T14:25:14Z

GH-102420 is a backport of this pull request to the 3.11 branch.

(cherry picked from commit c2bd55d) Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>

…102180) (#102419) * gh-102179: Fix `os.dup2` error reporting for negative fds (GH-102180) (cherry picked from commit c2bd55d) Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru> Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>

…on#102180)

* main: (21 commits) pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives in sub interpreters module (python#102472) pythongh-95672: Fix versionadded indentation of get_pagesize in test.rst (pythongh-102455) pythongh-102416: Do not memoize incorrectly loop rules in the parser (python#102467) pythonGH-101362: Optimise PurePath(PurePath(...)) (pythonGH-101667) pythonGH-101362: Check pathlib.Path flavour compatibility at import time (pythonGH-101664) pythonGH-101362: Call join() only when >1 argument supplied to pathlib.PurePath() (python#101665) pythongh-102444: Fix minor bugs in `test_typing` highlighted by pyflakes (python#102445) pythonGH-102341: Improve the test function for pow (python#102342) Fix unused classes in a typing test (pythonGH-102437) pythongh-101979: argparse: fix a bug where parentheses in metavar argument of add_argument() were dropped (python#102318) pythongh-102356: Add thrashcan macros to filter object dealloc (python#102426) Move around example in to_bytes() to avoid confusion (python#101595) pythonGH-97546: fix flaky asyncio `test_wait_for_race_condition` test (python#102421) pythongh-96821: Add config option `--with-strict-overflow` (python#96823) pythongh-101992: update pstlib module documentation (python#102133) pythongh-63301: Set exit code when tabnanny CLI exits on error (python#7699) pythongh-101863: Fix wrong comments in EUC-KR codec (pythongh-102417) pythongh-102302 Micro-optimize `inspect.Parameter.__hash__` (python#102303) pythongh-102179: Fix `os.dup2` error reporting for negative fds (python#102180) pythongh-101892: Fix `SystemError` when a callable iterator call exhausts the iterator (python#101896) ...

* main: (37 commits) pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives in sub interpreters module (python#102472) pythongh-95672: Fix versionadded indentation of get_pagesize in test.rst (pythongh-102455) pythongh-102416: Do not memoize incorrectly loop rules in the parser (python#102467) pythonGH-101362: Optimise PurePath(PurePath(...)) (pythonGH-101667) pythonGH-101362: Check pathlib.Path flavour compatibility at import time (pythonGH-101664) pythonGH-101362: Call join() only when >1 argument supplied to pathlib.PurePath() (python#101665) pythongh-102444: Fix minor bugs in `test_typing` highlighted by pyflakes (python#102445) pythonGH-102341: Improve the test function for pow (python#102342) Fix unused classes in a typing test (pythonGH-102437) pythongh-101979: argparse: fix a bug where parentheses in metavar argument of add_argument() were dropped (python#102318) pythongh-102356: Add thrashcan macros to filter object dealloc (python#102426) Move around example in to_bytes() to avoid confusion (python#101595) pythonGH-97546: fix flaky asyncio `test_wait_for_race_condition` test (python#102421) pythongh-96821: Add config option `--with-strict-overflow` (python#96823) pythongh-101992: update pstlib module documentation (python#102133) pythongh-63301: Set exit code when tabnanny CLI exits on error (python#7699) pythongh-101863: Fix wrong comments in EUC-KR codec (pythongh-102417) pythongh-102302 Micro-optimize `inspect.Parameter.__hash__` (python#102303) pythongh-102179: Fix `os.dup2` error reporting for negative fds (python#102180) pythongh-101892: Fix `SystemError` when a callable iterator call exhausts the iterator (python#101896) ...

bedevere-bot added the awaiting review label Feb 23, 2023

bedevere-bot mentioned this pull request Feb 23, 2023

os.dup2() raises wrong OSError for negative fds #102179

Closed

arhadthedev added the extension-modules C modules in the Modules dir label Feb 25, 2023

kumaraditya303 approved these changes Mar 3, 2023

View reviewed changes

Misc/NEWS.d/next/Library/2023-02-23-15-06-01.gh-issue-102179.P6KQ4c.rst Outdated Show resolved Hide resolved

bedevere-bot added awaiting merge and removed awaiting review labels Mar 3, 2023

Update Misc/NEWS.d/next/Library/2023-02-23-15-06-01.gh-issue-102179.P…

01df936

…6KQ4c.rst

kumaraditya303 self-assigned this Mar 3, 2023

kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 3, 2023

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 3, 2023

kumaraditya303 added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Mar 3, 2023

Skip the test case on Emscripten

c32ea70

kumaraditya303 approved these changes Mar 4, 2023

View reviewed changes

kumaraditya303 merged commit c2bd55d into python:main Mar 4, 2023

bedevere-bot removed the awaiting merge label Mar 4, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 4, 2023

pythongh-102179: Fix os.dup2 error reporting for negative fds (pyth…

9f6df8c

…onGH-102180) (cherry picked from commit c2bd55d) Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>

bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 4, 2023

kumaraditya303 added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Mar 4, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 4, 2023

pythongh-102179: Fix os.dup2 error reporting for negative fds (pyth…

4ae023d

…onGH-102180) (cherry picked from commit c2bd55d) Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>

bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 4, 2023

miss-islington added a commit that referenced this pull request Mar 4, 2023

gh-102179: Fix os.dup2 error reporting for negative fds (GH-102180)

cc6ce90

(cherry picked from commit c2bd55d) Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>

izbyshev deleted the gh-102179-dup2-negative-fd branch March 4, 2023 15:18

hugovk pushed a commit to hugovk/cpython that referenced this pull request Mar 6, 2023

pythongh-102179: Fix os.dup2 error reporting for negative fds (pyth…

1e09181

…on#102180)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

gh-102179: Fix os.dup2() error reporting for negative fds #102180

gh-102179: Fix os.dup2() error reporting for negative fds #102180

Uh oh!

izbyshev commented Feb 23, 2023 •

edited by bedevere-bot

Loading

Uh oh!

Uh oh!

bedevere-bot commented Mar 3, 2023

Uh oh!

kumaraditya303 commented Mar 4, 2023

Uh oh!

izbyshev commented Mar 4, 2023

Uh oh!

izbyshev commented Mar 4, 2023

Uh oh!

kumaraditya303 commented Mar 4, 2023

Uh oh!

miss-islington commented Mar 4, 2023

Uh oh!

miss-islington commented Mar 4, 2023

Uh oh!

bedevere-bot commented Mar 4, 2023

Uh oh!

miss-islington commented Mar 4, 2023

Uh oh!

bedevere-bot commented Mar 4, 2023

Uh oh!

Uh oh!

Uh oh!

gh-102179: Fix os.dup2() error reporting for negative fds #102180

gh-102179: Fix os.dup2() error reporting for negative fds #102180

Uh oh!

Conversation

izbyshev commented Feb 23, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Mar 3, 2023

Uh oh!

kumaraditya303 commented Mar 4, 2023

Uh oh!

izbyshev commented Mar 4, 2023

Uh oh!

izbyshev commented Mar 4, 2023

Uh oh!

kumaraditya303 commented Mar 4, 2023

Uh oh!

miss-islington commented Mar 4, 2023

Uh oh!

miss-islington commented Mar 4, 2023

Uh oh!

bedevere-bot commented Mar 4, 2023

Uh oh!

miss-islington commented Mar 4, 2023

Uh oh!

bedevere-bot commented Mar 4, 2023

Uh oh!

Uh oh!

izbyshev commented Feb 23, 2023 •

edited by bedevere-bot

Loading