Skip to content

gh-101277: Isolate itertools, add group and _grouper types to module state #101302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 1, 2023
Merged

gh-101277: Isolate itertools, add group and _grouper types to module state #101302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3ab0289
Add immutable types tests
erlend-aasland Jan 24, 2023
99406f8
gh-101277: establish global state
erlend-aasland Jan 24, 2023
50410bf
gh-101277: Add groupby and _grouper types to module state
erlend-aasland Jan 24, 2023
6dc2032
Merge branch 'main' into isolate-itertools/batch-1
erlend-aasland Jan 25, 2023
2cfe214
Sync with main
erlend-aasland Jan 29, 2023
f1e877b
Store state in groupbyobject
erlend-aasland Jan 29, 2023
a0f9b42
In _grouper_create, fetch state from groupbyobject->state
erlend-aasland Jan 29, 2023
51b3c6e
Removed now unused variable
erlend-aasland Jan 29, 2023
7aea9f6
Update Modules/itertoolsmodule.c
erlend-aasland Jan 31, 2023
10cb0bc
Include pycore_moduleobject.h bco. _PyModule_GetState()
erlend-aasland Jan 31, 2023
a64e69c
Make sure the include is inserted in alphabetical order
erlend-aasland Jan 31, 2023
4783565
Update Modules/itertoolsmodule.c
erlend-aasland Jan 31, 2023
cea6d40
Sync with main
erlend-aasland Jan 31, 2023
8a3b6df
Add get-state-by-cls helper and use it for subclass check
erlend-aasland Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions Lib/test/test_itertools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1694,6 +1694,38 @@ def test_zip_longest_result_gc(self):
gc.collect()
self.assertTrue(gc.is_tracked(next(it)))

@support.cpython_only
def test_immutable_types(self):
from itertools import _grouper, _tee, _tee_dataobject
dataset = (
accumulate,
batched,
chain,
combinations,
combinations_with_replacement,
compress,
count,
cycle,
dropwhile,
filterfalse,
groupby,
_grouper,
islice,
pairwise,
permutations,
product,
repeat,
starmap,
takewhile,
_tee,
_tee_dataobject,
zip_longest,
)
for tp in dataset:
with self.subTest(tp=tp):
with self.assertRaisesRegex(TypeError, "immutable"):
tp.foobar = 1


class TestExamples(unittest.TestCase):

Expand Down
8 changes: 4 additions & 4 deletions Modules/clinic/itertoolsmodule.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading