Skip to content

GH-100192: fix asyncio subprocess tests to pass env vars to subprocess #100569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2022
Merged

GH-100192: fix asyncio subprocess tests to pass env vars to subprocess #100569

merged 1 commit into from
Dec 28, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Dec 28, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Dec 28, 2022
Closed
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Dec 28, 2022
@kumaraditya303 kumaraditya303 added topic-asyncio tests Tests in the Lib/test dir skip news and removed tests Tests in the Lib/test dir awaiting core review labels Dec 28, 2022
@kumaraditya303
Copy link
Contributor Author

!buildbot .*RHEL7

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 9f93e6d 🤖

The command will test the builders whose names match following regular expression: .*RHEL7

The builders matched are:

  • AMD64 RHEL7 LTO PR
  • AMD64 RHEL7 PR
  • PPC64LE RHEL7 Refleaks PR
  • s390x RHEL7 PR
  • s390x RHEL7 Refleaks PR
  • PPC64LE RHEL7 PR
  • PPC64LE RHEL7 LTO PR
  • AMD64 RHEL7 Refleaks PR
  • AMD64 RHEL7 LTO + PGO PR
  • s390x RHEL7 LTO + PGO PR
  • s390x RHEL7 LTO PR
  • PPC64LE RHEL7 LTO + PGO PR

@kumaraditya303 kumaraditya303 mentioned this pull request Dec 28, 2022
Merged
gvanrossum
gvanrossum approved these changes Dec 28, 2022
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Those pesky buildbots! :-)

@kumaraditya303
Copy link
Contributor Author

Those pesky buildbots! :-)

I am used to it now ;)

@kumaraditya303 kumaraditya303 merged commit 6835184 into python:main Dec 28, 2022
@kumaraditya303 kumaraditya303 deleted the fix-buildbots branch December 28, 2022 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir topic-asyncio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kumaraditya303 @bedevere-bot @gvanrossum