Fix Memleak in ASVGD #2003
Merged
Fix Memleak in ASVGD #2003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perature and repulsion_temperature to the SteinVIState; renamed _svgd_loss_and_grads => _loss_and_grads; added loss and repulsion temperature to signature of _loss_and_grads
OlaRonning
commented
Mar 9, 2025
| @pytest.mark.xfail( | ||
| os.getenv("JAX_CHECK_TRACER_LEAKS") == "1", reason="Expected tracer leak" | ||
| ) | ||
| def test_run_smoke(kernel, problem, method): |
There was a problem hiding this comment.
@fehiepsi do I remove the mark.xfail decorator?
@pytest.mark.xfail(
os.getenv("JAX_CHECK_TRACER_LEAKS") == "1", reason="Expected tracer leak"
)There was a problem hiding this comment.
I'm going to follow this and remove it.
Running
JAX_CHECK_TRACER_LEAKS=1 pytest -vs test/contrib/einstein/test_steinvi.py
passes now.
There was a problem hiding this comment.
Could you also remove the CI test: https://github.com/pyro-ppl/numpyro/blob/master/.github/workflows/ci.yml#L88 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASVGDhad a memory leak caused by assigning a JAX Tracer to an attribute. This PR resolves the issue by introducing a state tuple that is passed along with the optimization process instead.Changes:
TODO
Add leak check to unit testsIgnored following: Fix tracer leak in svi with mutable state #2001Related to #1982