Add batch and event shape to repr.
#1946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlaRonning
reviewed
Jan 10, 2025
| def __repr__(self) -> str: | ||
| cls = self.__class__ | ||
| return ( | ||
| f"<{cls.__module__}.{cls.__name__} object at {id(self):#x} with batch " |
There was a problem hiding this comment.
What is the behavior of :#x in the f-string?
There was a problem hiding this comment.
The :#x formats the id of the object as a 0x[hex] to keep the repr method consistent with the default other than adding the shapes.
>>> from numpyro import distributions as dists
>>>
>>> d = dists.Normal().expand((5, 10, 7)).to_event(2)
>>> d
<numpyro.distributions.distribution.Independent object at 0x10723f7c0 with batch shape (5,) and event shape (10, 7)>
>>> object.__repr__(d)
'<numpyro.distributions.distribution.Independent object at 0x10723f7c0>'
OlaRonning
approved these changes
Jan 11, 2025
There was a problem hiding this comment.
Looks good! Thanks @tillahoffmann.
I checked print(Normal) and print(Normal()) and test case. All behave as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the batch and event shape to the representation of distributions to help with development and debugging.