This repository was archived by the owner on Jan 28, 2019. It is now read-only.
Provide the user/team IDs when handling authTest success #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks for the PR! One small change: can you make the closure take optional strings instead of force unwrapping here? I wouldn't want to be crashing here in the event of an API change by Slack. |
|
Done, and tested on my local Slack bot. |
|
Great, thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slack's API documentation seems to indicate that the best way to figure out "who am I" is to get the user and team ID from the JSON returned by the authentication test command.
This PR changes from using the SuccessClosure to a new AuthTestClosure that provides the user and team IDs to the caller.