Add NestedTypes to DynamicallyAccessedMember use #817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents nested types - e.g. child objects or arrays of child objects - from being removed by the linker when an application is trimmed. This only works at the moment in current unreleased versions of the .NET SDK (e.g. .NET 6 rc.1.21381.5). It does not work in any publicly released preview up to and including .NET 6 Preview 6. See dotnet/linker#2185 for more information.
mgravell
approved these changes
Aug 30, 2024
|
Sorry for delay; merging with thanks; will plan a deploy |
|
@mgravell can we get a new release with this please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents nested types - e.g. child objects or arrays of child objects - from being removed by the linker when an application is trimmed.
This only works at the moment in currently unreleased versions of the .NET SDK (e.g. v6.0.100-rc.1.21381.5). It does not work in any publicly released preview up to and including .NET 6 Preview 6.
I observed this when trying to make SteamKit trimmable and when trying to produce trimmed builds of DepotDownloader. Whilst simply "not having child objects" could be considered a valid workaround, we build directly from reverse-engineered protobuf files that we have no real control over.
See dotnet/linker#2185 for more information about use of the attribute.