Adds New SchemaGeneration Flag for Generating Prefixed Enum Members #1133
Conversation
| "; | ||
|
|
||
| [Fact] | ||
| public void ProtoIncludesEnumNamePrefix() |
There was a problem hiding this comment.
can we add a second test here, so we can immediately contrast with/without ?
| Assert.Equal(ExpectedProto, proto, ignoreLineEndingDifferences: true); | ||
| } | ||
|
|
||
| [ProtoContract] |
There was a problem hiding this comment.
can we add a second enum here with a [ProtoContract(Name = "SomethingElse")] to check that the generated prefix is SomethingElse_ ?
src/protobuf-net/Meta/MetaType.cs
Outdated
| @@ -2028,6 +2030,7 @@ public bool IsGroup | |||
| else if (Type.IsEnum) | |||
| { | |||
| var enums = GetEnumValues(); | |||
| string enumNamePrefix = $"{GetSchemaTypeName(callstack)}_"; | |||
There was a problem hiding this comment.
suggestion: = isEnumNamePrefixSupported ? $"{GetSchemaTypeName(callstack)}_" : ""; - that way the later uses can be simplified to just .Append(enumNamePrefix).Append(member.Name), which simplifies the code and avoids a bunch of unnecessary string allocations
src/protobuf-net/Meta/MetaType.cs
Outdated
| @@ -2080,11 +2084,13 @@ public bool IsGroup | |||
| if (parsed.HasValue) | |||
| { | |||
| if (parsed.Value == 0) continue; | |||
| NewLine(builder, indent + 1).Append(member.Name).Append(" = ").Append(parsed.Value).Append(';'); | |||
| NewLine(builder, indent + 1).Append(isEnumNamePrefixSupported ? $"{enumNamePrefix}{member.Name}" : member.Name).Append(" = ").Append(parsed.Value).Append(';'); | |||
There was a problem hiding this comment.
there's a semantic thing here for me to think about - "what should happen if the name was already explicitly specified? is it prefixed? (probably not)" - not 100% sure we know that currently; a job for me to worry about
|
This list is good, thanks! |
Adds Schema Generation Option for Prefixed Enum Members
Issue: protobuf-net/protobuf-net.Grpc#323