Suppress CS8981 in generated protos #1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgravell
reviewed
Nov 2, 2023
|
appreciate the assist - minor omission from the restore part, but in principle: +1 |
mgravell
approved these changes
Nov 2, 2023
|
test failures are related to this change; I can deal with that if you're too busy - I appreciate what you have done |
|
Missed these files somehow, should be good now. EDIT: Not sure what this EverythingProtoLangver3 test failure is about. |
|
The problem is 2 of:
Basically, when using down-level compilers, the compiler has no knowledge of that one; I'll merge as-is and apply a fix afterwards; appreciated! |
mgravell
added a commit
that referenced
this pull request
Jan 19, 2024
* dignostic CS8981 doesn't exist (as 8981 without prefix) in down-level compilers cross-ref #1107 * reorder to maintain output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1106