Skip to content

Address Broken Collection Sketch Links #3562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2025
Merged

Conversation

raclim
Copy link
Collaborator

@raclim raclim commented Jul 30, 2025

Fixes #3561

After upgrading node and mongoose, Collection items that use .populate() no longer consistently provide the projectId field as before. In these queries, mongoose now seems to favor returning a full project object with its own id instead of projectId, resulting in item.projectId breaking.

Changes:

  • Updates item.projectId to use the id from the project object instead to fix the missing sketch ids in the collection list URLs

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link

release-com bot commented Jul 30, 2025

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-33e7617ebe

@raclim raclim merged commit b6b6dcc into develop Jul 30, 2025
4 checks passed
@raclim raclim deleted the collection-sketch-links branch July 30, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unreachable sketch links from collection page
1 participant