Skip to content

Fix announcement id issues #11549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

thuanhuynhh
Copy link
Contributor

@thuanhuynhh thuanhuynhh commented Jun 20, 2025

for #11548

@asmecher asmecher requested a review from Vitaliy-1 June 20, 2025 19:46
@asmecher
Copy link
Member

@Vitaliy-1, this appears to be related to #10328 -- can you have a look? At a glance, the pluck call shouldn't reference a column name outside the container code.

Copy link
Contributor

@Vitaliy-1 Vitaliy-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @thuanhuynhh. The fix for the sitemap is already on main and stable branches. Could you update the branch through rebase, so changes in the other 2 classes can be merged?

@thuanhuynhh
Copy link
Contributor Author

Hi @Vitaliy-1
I have updated the branch.
Thank you so much

@Vitaliy-1
Copy link
Contributor

Thanks, I see that the branch is 35 commits behind pkp/pkp-lib:main. Usually we update feature branch through rebase. I see that fork's main is up to date, so it can be done through:

git checkout main
git pull
git checkout fix-annoucement-id
git rebase -i main

@thuanhuynhh
Copy link
Contributor Author

Hi @Vitaliy-1
I have updated branch
Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants