Tests/ParseSwiftTests/ParseMicrosoftCombineTests.swift (1)

89-358: ⚡ Quick win

Add Combine tests for insecure-mode Microsoft overloads.

The suite doesn’t currently exercise loginPublisher(id:accessToken:) and linkPublisher(id:accessToken:), so one supported auth mode remains unvalidated in this layer.

Proposed test additions

+    func testLoginInsecureMode() {
+        var subscriptions = Set<AnyCancellable>()
+        let expectation1 = XCTestExpectation(description: "Login insecure mode")
+
+        var serverResponse = LoginSignupResponse()
+        serverResponse.authData = [
+            serverResponse.microsoft.__type: [
+                "id": "testing-id",
+                "access_token": "testing-token"
+            ]
+        ]
+
+        let encoded = try! serverResponse.getEncoder().encode(serverResponse, skipKeys: .none)
+        MockURLProtocol.mockRequests { _ in
+            MockURLResponse(data: encoded, statusCode: 200, delay: 0.0)
+        }
+
+        User.microsoft.loginPublisher(id: "testing-id", accessToken: "testing-token")
+            .sink(receiveCompletion: { completion in
+                if case let .failure(error) = completion { XCTFail(error.localizedDescription) }
+                expectation1.fulfill()
+            }, receiveValue: { user in
+                XCTAssertEqual(user, User.current)
+                XCTAssertTrue(user.microsoft.isLinked)
+            })
+            .store(in: &subscriptions)
+
+        wait(for: [expectation1], timeout: 20.0)
+    }
+
+    func testLinkInsecureMode() throws {
+        var subscriptions = Set<AnyCancellable>()
+        let expectation1 = XCTestExpectation(description: "Link insecure mode")
+
+        _ = try loginNormally()
+        MockURLProtocol.removeAll()
+
+        let serverResponse = LoginSignupResponse()
+        let encoded = try! serverResponse.getEncoder().encode(serverResponse, skipKeys: .none)
+        MockURLProtocol.mockRequests { _ in
+            MockURLResponse(data: encoded, statusCode: 200, delay: 0.0)
+        }
+
+        User.microsoft.linkPublisher(id: "testing-id", accessToken: "testing-token")
+            .sink(receiveCompletion: { completion in
+                if case let .failure(error) = completion { XCTFail(error.localizedDescription) }
+                expectation1.fulfill()
+            }, receiveValue: { user in
+                XCTAssertEqual(user, User.current)
+                XCTAssertTrue(user.microsoft.isLinked)
+            })
+            .store(in: &subscriptions)
+
+        wait(for: [expectation1], timeout: 20.0)
+    }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Tests/ParseSwiftTests/ParseMicrosoftCombineTests.swift` around lines 89 -
358, Add Combine tests that call the insecure-mode Microsoft overloads by
duplicating the pattern from testLoginAuthData and testLinkAuthData: create a
serverResponse (LoginSignupResponse), encode/decode to produce userOnServer,
mock the network with MockURLProtocol.mockRequests returning the encoded
response, build authData via
ParseMicrosoft<User>.AuthenticationKeys.id.makeDictionary(id: "testing",
accessToken: "token_value") and then call
User.microsoft.loginPublisher(id:accessToken:) and
User.microsoft.linkPublisher(id:accessToken:) respectively, subscribing and
asserting equality with User.current, userOnServer properties, and that
microsoft.isLinked is true; name the new tests e.g. testLoginInsecureMode and
testLinkInsecureMode and mirror the existing expectation/store logic so they
follow the same structure as the other Combine tests.

Tests/ParseSwiftTests/ParseMicrosoftTests.swift (1)

116-121: ⚡ Quick win

Consider adding end-to-end tests for insecure auth mode.

While this test verifies dictionary construction for the insecure auth mode (id + access_token), there are no tests that actually call login(id:accessToken:) or link(id:accessToken:) through the full flow with mock server responses. The PR summary states that two auth payload modes are supported, but only the secure OAuth flow (code + redirect_uri) is tested end-to-end.

🧪 Suggested test additions

Add tests similar to testLogin and testLinkLoggedInUserWithMicrosoft, but using:

User.microsoft.login(id: "user_id", accessToken: "access_token") { result in
    // assertions
}

This would ensure the insecure auth mode works correctly through the complete authentication flow.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Tests/ParseSwiftTests/ParseMicrosoftTests.swift` around lines 116 - 121, Add
end-to-end tests that exercise the insecure auth payload path (id +
access_token) by invoking User.microsoft.login(id:accessToken:){...} and
User.microsoft.link(id:accessToken:){...} and asserting success/failure and
server request/response handling just like the existing testLogin and
testLinkLoggedInUserWithMicrosoft tests; ensure the tests use mock server
responses matching the insecure payload built by
ParseMicrosoft.AuthenticationKeys.id.makeDictionary(id:accessToken:) and verify
the created/linked user state and any returned session/token fields.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes