Add kwarg to setup query #166
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. Could you add a test for this yet? |
|
Thanks for this. I think it will be addressed by #167 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In recent versions of Django, the
setup_query()method of theSQLCompileraccepts a keywordwith_col_aliases. As it currently stands, the method override inSQLCopyToCompilerdoesn't accept any keywords. So ifwith_col_aliases=Xis passed toSQLCopyToCompiler's method, you'll get aTypeError. This PR should fix this, and I don't think it will break in older versions of Django.Tested with Django 4.2.1. I haven't tested an older version. I believe Django 4.0 lacks the
with_col_aliaseskeyword if someone else is up for it.