[#787] 로컬 웹뷰 마크다운 렌더러를 모듈화한다 - #788
Merged
Merged
Conversation
opficdev
marked this pull request as draft
August 1, 2026 03:32
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afd35957e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
PresentationShared에서 분리하여 재사용 가능한 라이브러리 경계 구성TodoMarkdownContentView로 제한WKWebView스크롤과 하단 가림 영역 처리 동작 보존📝 작업 내용
📌 요약
Libraries/MarkdownRenderer모듈 신설 및 workspace 등록MarkdownRendererReference의 참조 계약 범용화TodoMarkdownContentView를 단일 앱 연결점으로 정리MarkdownRenderer자원 탐색 테스트 및 CI 검증 경로 추가🔍 상세
MarkdownRenderer 모듈 구성
Libraries/MarkdownRenderer/Project.swift추가packages: []와.folderReference(path: "Resources/MarkdownRenderer")명시MarkdownRenderer및MarkdownRendererTeststarget 구성Workspace.swift와Application/Presentation/Project.swift에 모듈 및 의존성 등록SwiftUI,WebKit,Foundation,CoreGraphics외 DevLog 앱 계층 의존성 차단MarkdownRendererBundleTests를 통한 실제index.html자원 탐색 경로 확인앱 연결 경계 정리
MarkdownRendererView와MarkdownRendererReference만 공개 API로 제공MarkdownRendererReference의todoID계약을 범용referenceID계약으로 변경MarkdownRendererView내부로 이동TodoMarkdownContentView에서 Todo 참조 변환, SF Symbol 이미지 생성, 탭바 높이 및 callback 변환 책임 유지TodoMarkdownContentView만MarkdownRenderer를 직접 import하도록 제한@_exported import MarkdownRenderer를 사용하지 않는 재노출 방지 구조 구성기존 동작 보존
WKWebView내부 스크롤 소유권 유지obscuredContentInsets.bottom을 통한 iOS 26 하단 가림 영역 처리 유지자원 및 Tooling 이전
Tools/MarkdownRenderer를Libraries/MarkdownRenderer/Tooling으로 이동Libraries/MarkdownRenderer/Resources/MarkdownRenderer로 이동.gitignore와.gitattributes의 렌더러 자원 경로 갱신CI 및 문서 정비
Libraries/**/Project.swift추가Libraries및MarkdownRendererscheme 추가Libraries/${TEST_SCHEME}/Tests테스트 경로 탐색 분기 추가.agents/rules/architecture.md와README.md에MarkdownRenderer소유권 및 의존성 경계 추가AGENTS.md에서 존재하지 않는.gemini/styleguide.md선행 읽기 요구 제거