CONSOLE-4841: Move CSP from plugin to redux store + some sdk adoption prep work #15633
Conversation
|
@logonoff: This pull request references CONSOLE-4841 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label px-approved /assign @yapei @vojtechszocs |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
frontend/packages/console-app/src/components/console-operator/ConsoleOperatorConfig.tsx
Outdated
Show resolved
Hide resolved
...tend/packages/console-app/src/components/console-operator/ConsolePluginDescriptionDetail.tsx
Show resolved
Hide resolved
f6d4500 to
ec2bf9d
Compare
8c88a87 to
543a22c
Compare
b78cc39 to
c9cc5f5
Compare
f4e415c to
0938623
Compare
CSP violations are now stored in the `store.UI.pluginCSPViolations[pluginName]` as a boolean for whether a violation has been committed. Removes `setCustomDynamicPluginInfo` and `findDynamicPluginInfo` because they will not be included in `openshift/dynamic-plugin-sdk`. There should be no functional or UI changes in this PR, everything should remain the same to an end user.
Also remove `usePluginInfo` and `usePluginStore` from the barrel file so we can move towards removing the barrel file entirely
It's used in one spot which we can remove
0938623 to
7717f17
Compare
|
@logonoff: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
CSP violations are now stored in the
store.UI.pluginCSPViolations[pluginName]as a boolean for whether a violation has been committed.Removes
setCustomDynamicPluginInfoandfindDynamicPluginInfobecause they will not be included inopenshift/dynamic-plugin-sdk.There should be no functional or UI changes in this PR, everything should remain the same to an end user.