-
-
Notifications
You must be signed in to change notification settings - Fork 56.3k
FFmpeg 8.0 support. #27691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.x
Are you sure you want to change the base?
FFmpeg 8.0 support. #27691
Conversation
@@ -685,7 +685,10 @@ void CvCapture_FFMPEG::close() | |||
if( video_st ) | |||
{ | |||
#ifdef CV_FFMPEG_CODECPAR | |||
// avcodec_close removed in FFmpeg release 8.0 | |||
# if (LIBAVCODEC_BUILD < CALC_FFMPEG_VERSION(62, 11, 100)) | |||
avcodec_close( context ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
avcodec_free_context in the #else
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be avcodec_free_context(&context);
for any version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is avcodec_free_context at line 699. Is not it enough?
@opencv-alalek Could I merge this? |
@asmorkalov let's merge |
Address #27688
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.