Files api: add "receive", "receive content" and "delete" #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very impressive pull request. Good job! Feel free to continue, and implement other methods. ✅ |
Closed
gehrisandro
pushed a commit
that referenced
this pull request
May 16, 2024
Fix broken tests on assistant streaming
asaveiadelin
pushed a commit
to asaveiadelin/openAiPhp-client
that referenced
this pull request
Nov 4, 2024
…m(): Argument openai-php#1 () must be of type array, string given,
asaveiadelin
pushed a commit
to asaveiadelin/openAiPhp-client
that referenced
this pull request
Nov 4, 2024
…-php#1 () must be of type array, string given
mayconmedeiroz
pushed a commit
to mayconmedeiroz/client
that referenced
this pull request
Feb 4, 2025
Allow custom model name
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @nunomaduro
I had a little time and extended the files api a bit.
Was not 100% sure how we should approach the content receiving as this will not follow the REST convention to return an array. Instead it returns just a string.
In order to keep the type definitions as tight as possible I've added a new method (
requestContent()) on the Transport. Hope this is fine for you. Otherwise just let me know.