feat(client): propagate AbortSignal reason to APIUserAbortError #1611
+27
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
This PR enhances the error handling for aborted requests by propagating the abort reason from the AbortSignal to the APIUserAbortError.
What changed:
APIUserAbortError
instantiation to include the abort signal's reason as the error messageclient.ts
whereAPIUserAbortError
is thrown to pass the abort reasonWhy this is useful:
controller.abort('user cancelled')
) and receive them in error handlersAdditional context & links
This change addresses the common use case where applications need to distinguish between different types of request cancellations (user-initiated vs timeout vs navigation away, etc.). By propagating the abort reason, error handlers can make more informed decisions about how to respond to aborted requests.
Example usage: