-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Feat: separate tool_call_item and tool_call_output_item in stream events #974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
import asyncio | ||
import time | ||
|
||
import pytest | ||
|
||
from agents import Agent, Runner, function_tool | ||
|
||
from .fake_model import FakeModel | ||
from .test_responses import get_function_tool_call, get_text_message | ||
|
||
|
||
@function_tool | ||
async def foo() -> str: | ||
await asyncio.sleep(3) | ||
return "success!" | ||
|
||
@pytest.mark.asyncio | ||
async def test_stream_events_main(): | ||
model = FakeModel() | ||
agent = Agent( | ||
name="Joker", | ||
model=model, | ||
tools=[foo], | ||
) | ||
|
||
model.add_multiple_turn_outputs( | ||
[ | ||
# First turn: a message and tool call | ||
[ | ||
get_text_message("a_message"), | ||
get_function_tool_call("foo", ""), | ||
], | ||
# Second turn: text message | ||
[get_text_message("done")], | ||
] | ||
) | ||
|
||
result = Runner.run_streamed( | ||
agent, | ||
input="Hello", | ||
) | ||
tool_call_start_time = -1 | ||
tool_call_end_time = -1 | ||
async for event in result.stream_events(): | ||
if event.type == "run_item_stream_event": | ||
if event.item.type == "tool_call_item": | ||
tool_call_start_time = time.time_ns() | ||
elif event.item.type == "tool_call_output_item": | ||
tool_call_end_time = time.time_ns() | ||
|
||
assert tool_call_start_time > 0, "tool_call_item was not observed" | ||
assert tool_call_end_time > 0, "tool_call_output_item was not observed" | ||
assert tool_call_start_time < tool_call_end_time, "Tool call ended before or equals it started?" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be better to instead capture all the events and do a snapshot() to ensure they are in the right order + params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The order of these events is correct, but
tool_call_item
is triggered immediately aftertool_call_output_item
(upon tool call completion), not at the start of the tool call.