Skip to content

Add safety check handling for ComputerTool #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

Add safety check handling for ComputerTool #923

merged 1 commit into from
Jun 27, 2025

Conversation

rm-openai
Copy link
Collaborator

@rm-openai rm-openai commented Jun 23, 2025 •
edited
Loading

Summary

  • handle safety checks when using computer tools
  • expose new on_safety_check callback and data structure
  • return acknowledged checks in computer output
  • test acknowledging safety checks

Test plan

  • make format
  • make lint
  • make mypy
  • make tests

Resolves #843

https://chatgpt.com/codex/tasks/task_i_684f207b8b588321a33642a2a9c96a1a

@seratch seratch added enhancement New feature or request feature:core labels Jun 25, 2025
@dnwarnock
Copy link

Any idea when this will be merged and released?

@rm-openai rm-openai merged commit 8664271 into main Jun 27, 2025
5 checks passed
@rm-openai rm-openai deleted the codex/add-safety-check-acknowledgment-param-in-computertool branch June 27, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakrym-oai pakrym-oai pakrym-oai approved these changes

Assignees

@pakrym-oai pakrym-oai

Labels
codex enhancement New feature or request feature:core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

acknowledged_safety_checks during response
4 participants
@rm-openai @dnwarnock @pakrym-oai @seratch