feat: add retry logic to MCP server operations #1554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonbaker-openai
approved these changes
Aug 21, 2025
| @@ -267,15 +290,17 @@ async def list_tools( | |||
| """List the tools available on the server.""" | |||
| if not self.session: | |||
| raise UserError("Server not initialized. Make sure you call `connect()` first.") | |||
| session = self.session | |||
| assert session is not None | |||
There was a problem hiding this comment.
super nit: Feels silly to assert is not None right below the early exception on if not self.session
| @@ -290,8 +315,10 @@ async def call_tool(self, tool_name: str, arguments: dict[str, Any] | None) -> C | |||
| """Invoke a tool on the server.""" | |||
| if not self.session: | |||
| raise UserError("Server not initialized. Make sure you call `connect()` first.") | |||
| session = self.session | |||
| assert session is not None | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
max_retry_attempts(supporting-1for unlimited retries) andretry_backoff_seconds_basecall_toolandlist_toolsretry appropriatelyTesting
make lintmake mypymake test(fails: No rule to make target 'test')make testsmake old_version_tests(fails: Request failed after 3 retries (tunnel error))https://chatgpt.com/codex/tasks/task_i_68a73cab8b9c8321876f6f3dd1dfcd20