Fix type annotation and clarify tool behavior docs #1355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… docs This commit improves type safety by replacing Any with the correct generic type TContext in the get\_all\_tools method. It also avoids confusion by renaming the input parameter in the run\_agent function to user\_input because input is a built-in function in Python. Lastly, it updates the documentation of tool\_use\_behavior to clearly describe the use of the StopAtTools object instead of a plain list of tool names. These changes make the code more accurate, easier to understand, and better aligned with best practices.
Use user\_input instead of input to avoid passing the built-in function by mistake.
seratch
requested changes
Aug 3, 2025
| @@ -101,7 +101,7 @@ async def get_mcp_tools(self, run_context: RunContextWrapper[TContext]) -> list[ | |||
| self.mcp_servers, convert_schemas_to_strict, run_context, self | |||
| ) | |||
|
|
|||
| async def get_all_tools(self, run_context: RunContextWrapper[Any]) -> list[Tool]: | |||
| async def get_all_tools(self, run_context: RunContextWrapper[TContext]) -> list[Tool]: | |||
seratch
approved these changes
Aug 3, 2025
vcshih
pushed a commit
to veris-ai/openai-agents-python
that referenced
this pull request
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves type safety by replacing Any with the correct generic type TContext in the get_all_tools method.
It also avoids confusion by renaming the input parameter in the run_agent function to user_input because input is a built-in function in Python.
Lastly, it updates the documentation of tool_use_behavior to clearly describe the use of the StopAtTools object instead of a plain list of tool names.
These changes make the code more accurate, easier to understand, and better aligned with best practices.