Update vertexai instrumentation to be in-line with the latest semantic conventions #3709
Conversation
|
I'm confused by the Maybe the value of that envvar should just be a version number, and every new version which has breaking changes we put them behind a gate with that version number ? If a user sets the env var to v3, they get all breaking changes from v1/v2/v3, there will be no way to pick and choose which breaking changes they get.. But making all the permutations of breaking changes opt-in is kind of a pain.. I suppose the flag is repeated so we could let users specify multiple versions in it, to get just the breaking changes they want.. Users will be opted-in to the non-breaking semantic convention changes by default, I think that is fine.. I don't like that new users have to know to set this env var and don't get all the newest stuff by default.. Would be interested in others thoughts on this.. |
Description
Start making changes to implement the big semantic convention changes made in open-telemetry/semantic-conventions#2179.
Now only a single event (
gen_ai.client.inference.operation.details) is used to capture Chat History. These changes will be opt-in, users will need to set the environment variable OTEL_SEMCONV_STABILITY_OPT_IN togen_ai_latest_experimentalto see them.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tests
Does This PR Require a Core Repo Change?
No.. We should wait for a sem conv release (and core repo to pick that up) before releasing this change, but I don't this PR needs to wait for those.
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.