-
Notifications
You must be signed in to change notification settings - Fork 735
Logging API hide std_to_otel function to convert python logging severity to otel severity #4649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, confirmed that std_to_otel isn't used anywhere in contrib either. I'm pretty sure the aio-pika test failure is unrelated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During a quick search on GitHub, I found this. It looks like a few repositories are already using it, but I’d rather deal with breakages now than after the signal is marked as stable. Would like to have some thoughts from maintainers.
This should be fine since the signal is experimental. |
Discovered this PR after finding a breaking change in our logging handler when updating to 1.35.0. For our use case, we do not want to depend on the SDK, which is now required after this change. I suspect other folks implementing custom logging handlers are in the same position. |
If you are using another sdk implementation, you can just reimplement the thing there? |
I also have a custom exporter for structlog. It was using this |
Given the small footprint, we copied |
Well, this is a different use case and possibly the reason why this was in the api 😅 |
Also ended up copying the function into my own code |
Description
Hide unexpected method in Logs API, this is only being used internally by LoggerHandler
Fixes #4314
Type of change
Please delete options that are not relevant.