Permit to override default OTLP HTTP exporter headers #4634
+60
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emdneto
reviewed
Jun 18, 2025
exporter/opentelemetry-exporter-otlp-proto-grpc/tests/test_otlp_metrics_exporter.py
Outdated
Show resolved
Hide resolved
xrmx
commented
Jun 24, 2025
There was a problem hiding this comment.
Wondering if instead of that we should make the default headers substituted via an entry point (or even make them a param for the init functions called by _initialize_components) so that we have a different mechanism that the user cannot easily override. This is because otherwise users setting OTEL_EXPORTER_OTLP_HEADERS will always override what distro sets.
dadd176 to
6f3b497
Compare
6f3b497 to
68776af
Compare
|
So this updates the otlp http exporters to match what the grpc ones are doing wrt channel_options that is that users are able to override the defaults but not remove them. |
|
Related to this the specs is being updated for allowing the update of users of the user agent: open-telemetry/opentelemetry-specification#4560 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We would like being able to use a specific user agent on our distro in order to discriminate OTLP traffic between our distro and upstream. At the moment this is not possible because HTTP exporters always override the passed headers with the default ones.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: