Ready for review. Thanks in advance for the feedback!

@dbarker fyi no need to update this at every commit, we usually merge main before merging or during reviews 😅

@dbarker fyi no need to update this at every commit, we usually merge main before merging or during reviews 😅

haha.. thanks for the heads up and review. Just making sure it is up to date and conflict free.. :)

@xrmx Any chance you can review this week? I'd like to get this in for the next release if possible. Happy to address any issues you see. Thanks.

I've resolved the conflicts. Anything else needed to run CI and merge?

Q: #4358 (comment)

Btw., I would call this a "new feature" not a bug fix.
Even though the Python API is not extended, the binary output "ABI?" is essentially extended and thus has feature-like implications on other OTEL components.

Btw., I would call this a "new feature" not a bug fix. Even though the Python API is not extended, the binary output "ABI?" is essentially extended and thus has feature-like implications on other OTEL components.

I agree this could easily be considered a feature since it covers a few items in the spec that may have come out since the otlp-proto-common module was implemented. The protobuf otlp spec version doesn't change with this though so no worries about an interface impact.

Belated +1 on the inclusion of the missing InstrumentationScope.attributes!

1.31.0 has been released including this change.
I don't see schema URLs in the output in the default, naive setup though.
Is it so that the SDK doesn't actually set the schema URLs?

1.31.0 has been released including this change. I don't see schema URLs in the output in the default, naive setup though. Is it so that the SDK doesn't actually set the schema URLs?

@dimaqq I can see scope schema urls and attributes coming through to the otel-collector debug exporter in my application (testing main at db2dd1e today). This is working for me with metrics and traces.

Here is an example of the scope attributes and schema url on ScopeSpans.

ResourceSpans #2
Resource SchemaURL: 
Resource attributes:
     -> telemetry.sdk.language: Str(python)
     -> telemetry.sdk.name: Str(opentelemetry)
     -> telemetry.sdk.version: Str(1.32.0.dev0)
     -> service.name: Str(service_client_py)
     -> host.name: Str(dev_host)
     -> host.arch: Str(amd64)
     -> process.executable.name: Str(service_client_py)
     -> ros.distro.name: Str(jazzy)
     -> ros.distro.version: Str(2)
     -> ros.version.rclpy: Str(7.1.2)
ScopeSpans #0
ScopeSpans SchemaURL: hello!
InstrumentationScope ros2_opentelemetry_service_client 
InstrumentationScope attributes:
     -> ros.node.name: Str(service_client_py)
     -> ros.node.namespace: Str(/)
     -> ros.entity.type: Str(service_client)
     -> ros.service.name: Str(/add_three_ints)

Right, I figured as much.

If the url is manually set, it’s exported, but the SDK doesn’t set the urls by default. That is for the “opentelemetry” parts like the resource in your example.