Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a look at adding support for MSI (#1211) and ran into a couple of issues.
Pymsi requires a path or BytesIO -- is there a way to convert from an unblob file? I was looking at
file_utils.OffsetFile
which seems closer (might need pymsi to support file-like objects, @nightlark). I made the following changes:And in pymsi changed the
__init__
for Package to:This seems to work but I'm not sure if there's an easier way.
I'm getting an error related to sandboxing which I suspect is unrelated:
I've been testing with a 7zip MSI downloaded from here:
https://www.7-zip.org/a/7z2501.msi
Finally, I commented out an entry in
DEFAULT_SKIP_MAGIC
to get the new handler called. I don't know what other side effects this will have.Any suggestions?