TYP: accept non-integer shapes in array constructor without a dtype #28498
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mypy_primer output from #28497 (comment) shows that calling
np.zeros
withtuple[int, np.int64]
results in a typing error. This PR intended to address that.But for some reason, I wasn't able to reproduce this error, and tese changes also did not result in a mypy_primer diff 🤷🏻
Either way, even if these changes don't actually fix this specific problem, I can imagine that there are some theoretical edge-cases where will help, although those are probably rather unlikely use-cases.
These changes are backwards compatible, and there are no other downsides that this would cause, as far as I can tell.