Skip to content

CI: pin scipy-doctest to 1.5.1 #28020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2024
Merged

CI: pin scipy-doctest to 1.5.1 #28020

merged 2 commits into from
Dec 17, 2024

Conversation

mattip
Copy link
Member

@mattip mattip commented Dec 17, 2024

Fixes #28019

@mattip
Copy link
Member Author

mattip commented Dec 17, 2024

Should we remove the doctest run from benchmarking? There was a reason we added it there but I can't remember it...

@seberg
Copy link
Member

seberg commented Dec 17, 2024

Should we remove the doctest run from benchmarking? There was a reason we added it there but I can't remember it...

It adds a second architecture to it, but I am not sure that was the reason. So yeah, I am seems OK to remove it (or rename for clarity).

Copy link
Member

@seberg seberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once tests pass. No opinion about hypothesis, but it does update very often and I think it has caused flaky tests before.

@ev-br
Copy link
Contributor

ev-br commented Dec 17, 2024

FWIW, I don't expect much activity on scipy-doctest going forward. So far two recent releases were hotfixes to numpy 2.2 repr change and now recently discovered issues with dtype methods. That said, I did not anticipate either of these either :-).

Anyhow, the majority (or all of) gh-28019 needs docstring fixes the numpy side, there's not much scipy-doctest can do. IOW, if you pin it now, there's no bugfix scipy-doctest release to fix the current breakage in numpy.

@charris
Copy link
Member

charris commented Dec 17, 2024

I'd like a pin in the maintenance/2.2.x branch as I don't want to deal with lots of doc fixes during its lifetime.

@charris
Copy link
Member

charris commented Dec 17, 2024

I'm not worried about the lint failures, they are an artifact of recent updates and I expect they will get fixed in the near future.

@seberg seberg changed the title pin scipy-doctest to 1.5.1 CI: pin scipy-doctest to 1.5.1 Dec 17, 2024
@seberg seberg added the 09 - Backport-Candidate PRs tagged should be backported label Dec 17, 2024
@seberg
Copy link
Member

seberg commented Dec 17, 2024

Good point, for maintenance I think the hypothesis pin also makes sense definitely.

Yes, we still should clean out these failures ASAP anyway, but let's put it in for now. Thanks Matti!

@seberg seberg merged commit 4764659 into numpy:main Dec 17, 2024
65 of 66 checks passed
charris pushed a commit to charris/numpy that referenced this pull request Dec 17, 2024
Pin scipy-doctest to 1.5.1 until new errors in previously uncovered tests are fixed.
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TST,DOC: Bump scipy_doctest (or remove pin) and fix new failures
4 participants