-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
CI: pin scipy-doctest to 1.5.1 #28020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should we remove the doctest run from benchmarking? There was a reason we added it there but I can't remember it... |
It adds a second architecture to it, but I am not sure that was the reason. So yeah, I am seems OK to remove it (or rename for clarity). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, once tests pass. No opinion about hypothesis, but it does update very often and I think it has caused flaky tests before.
FWIW, I don't expect much activity on scipy-doctest going forward. So far two recent releases were hotfixes to numpy 2.2 repr change and now recently discovered issues with dtype methods. That said, I did not anticipate either of these either :-). Anyhow, the majority (or all of) gh-28019 needs docstring fixes the numpy side, there's not much scipy-doctest can do. IOW, if you pin it now, there's no bugfix scipy-doctest release to fix the current breakage in numpy. |
I'd like a pin in the |
I'm not worried about the lint failures, they are an artifact of recent updates and I expect they will get fixed in the near future. |
Good point, for maintenance I think the hypothesis pin also makes sense definitely. Yes, we still should clean out these failures ASAP anyway, but let's put it in for now. Thanks Matti! |
Pin scipy-doctest to 1.5.1 until new errors in previously uncovered tests are fixed.
Fixes #28019