Skip to content

fix: oidc visibility check for provenance #8467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 30, 2025
Merged

Conversation

reggi
Copy link
Contributor

@reggi reggi commented Jul 29, 2025

When someone with a public repository and a private package attempts to publish with OIDC, the publish command will fail because provenance is enabled, there is currently no visibility check before auto enabling provenance.

This is a very rare edge case, but it's still incorrect. OIDC will always gracefully fail, but provenance does not.

  • This fix adds all the provenance related code after the OIDC auth token is set.
  • This requires provenance to be in the default config state (not set by the user) for OIDC to even consider auto-enabling provannece.

@reggi reggi requested a review from a team as a code owner July 29, 2025 15:36
reggi and others added 2 commits July 29, 2025 16:56
Co-authored-by: Gar <gar+gh@danger.computer>
Co-authored-by: Gar <gar+gh@danger.computer>
@reggi reggi merged commit 7d900c4 into latest Jul 30, 2025
20 checks passed
@reggi reggi deleted the reggi/oidc-private-prov branch July 30, 2025 19:26
@github-actions github-actions bot mentioned this pull request Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants