Skip to content

src: add comment for TicketKeyCallback #13193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: add comment for TicketKeyCallback #13193

wants to merge 1 commit into from

Conversation

@addaleax
Copy link
Member

Fixes: #13176

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels May 24, 2017
refack
refack reviewed May 24, 2017
View reviewed changes
src/node_crypto.cc


// Currently, EnableTicketKeyCallback and TicketKeyCallback are only present for
// the regression test in test/parallel/test-https-resume-after-renew.js.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion] If i understand this case correctly add , they are considered private until decided otherwise.
Also maybe add _ to the JS binding.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it’s implied that they are private when they are only there for tests. Also, this is only on the _handle property, so I think we’re good.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@addaleax
Copy link
Member Author

Landed in e2f2d18

@addaleax addaleax closed this May 26, 2017
@addaleax addaleax deleted the ticketkeycallback-comment branch May 26, 2017 15:59
addaleax added a commit that referenced this pull request May 26, 2017
@addaleax
src: add comment for TicketKeyCallback
e2f2d18 
Fixes: #13176
PR-URL: #13193
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
jasnell pushed a commit that referenced this pull request May 28, 2017
@addaleax @jasnell
src: add comment for TicketKeyCallback
145ab05 
Fixes: #13176
PR-URL: #13193
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@jasnell jasnell mentioned this pull request May 28, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
MylesBorins pushed a commit that referenced this pull request Jul 17, 2017
@addaleax @MylesBorins
src: add comment for TicketKeyCallback
48f00b5 
Fixes: #13176
PR-URL: #13193
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Merged
@ryan-ally ryan-ally mentioned this pull request Jun 20, 2023
Open
@aliscco aliscco mentioned this pull request Jun 20, 2023
Open
@ron-a20 ron-a20 mentioned this pull request Jun 21, 2023
Open
@137717unity 137717unity mentioned this pull request Jun 21, 2023
Open
@aliscco aliscco mentioned this pull request Jun 21, 2023
Open
@adamlaska adamlaska mentioned this pull request Jun 21, 2023
Open
This was referenced Jun 21, 2023
Open
Open
@wedataintelligence wedataintelligence mentioned this pull request Jun 21, 2023
Open
This was referenced Jun 21, 2023
Open
Open
Open
@MaxMood96 MaxMood96 mentioned this pull request Jun 22, 2023
Open
This was referenced Jun 22, 2023
Open
Open
@baby636 baby636 mentioned this pull request Jun 22, 2023
Open
@aliscco aliscco mentioned this pull request Jun 22, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Jun 22, 2023
Open
This was referenced Jun 22, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@kissofire kissofire mentioned this pull request Jun 25, 2023
Open
This was referenced Jul 6, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

+1 more reviewer

@refack refack refack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

What does SecureContext::EnableTicketKeyCallback do?

6 participants

@addaleax @refack @lpinca @cjihrig @MylesBorins @nodejs-github-bot