-
Notifications
You must be signed in to change notification settings - Fork 698
Added Arm64 support for Windows and Linux #1993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
* improved OpenSSL download and compile on Windows * increased the default Visual Studio Build Tools to 2019 as this is the default installed also with NodeJS 18+ and also includes arm64 support * increased the OpenSSL version to 1.1.1w for arm64 support * implemented arm64 compile support for Windows in acquireOpenSSL.js and libgit2.gyp * implemented arm64 compile support for Linux with arm64
Thank you! I can't make any promises when I'll be able to look at this but I do want to add support for this. |
@zawata maybe you can add this one as well, when you are bumping nan also |
@gpetrov It's out of scope right now unfortunately. I have a couple comments on your approach here and outside of this PR, https://github.com/nodegit/electron-npg-automator will need to be updated as well. I don't think arm64 runners are available outside of enterprise orgs right now, but I'd love to research that as well(maybe GK can help somehow?). That being said we've been researching support for arm64 builds internally, Nodegit is absolutely a blocker for that so we'll be able utilize this work. My comments:
I sketched out some of these changes when I was researching windows-arm64 a couple weeks ago, but they're not tested for anything other-than windows-arm64 hosts. |
Thanks @zawata for the feedback. You can indeed finetune the VS 2022 support. I was able to fully build the windows Arm64 nodegit binaries and deploy them. The build was done on an windows 11 Arm64 VM hosted on my MacBook Pro with M1pro ran by UTM https://mac.getutm.app Also there are windows Arm64 runners available: |
This is also how I tested it. I was under the assumption that Visual Studio 2022 was required for native-arm64 builds but if I'm mistaken then vs2019 is a better minimum. I'm still hoping we can have better version selection than hard-coding the path to 2019 and falling back to a non-standard npm-config item.
Yes, but they're only available as dedicated larger-runners. Open-source projects like nodegit can't configure windows and linux arm64 runners yet. |
It's better to have visual studio 2022 for best Arm64 support, see: https://learn.microsoft.com/en-us/visualstudio/install/visual-studio-on-arm-devices?view=vs-2022 |
@zawata could you please check also this PR - it is a good addition as well now that you are pushing some updates. |
Can you check @ianhattendorf