Skip to content

fix(go.d): create vnode internal data_collection_status charts in the main context #20872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2025

Conversation

ilyam8
Copy link
Member

@ilyam8 ilyam8 commented Aug 22, 2025

Summary
Test Plan
Additional Information
For users: How does this change affect me?

@github-actions github-actions bot added area/collectors Everything related to data collection collectors/go.d area/go labels Aug 22, 2025
@ilyam8 ilyam8 requested a review from Copilot August 22, 2025 09:11
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the creation of internal data collection status charts by ensuring they are created in the main context rather than the vnode context. The change moves the chart creation logic to use an empty HOST context instead of the vnode GUID.

  • Moves data collection status and duration chart creation from vnode context to main context
  • Reorganizes HOST context switching to properly isolate chart creation contexts
  • Updates cleanup logic to create charts in the correct context

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ilyam8 ilyam8 marked this pull request as ready for review August 22, 2025 09:14
@ilyam8 ilyam8 merged commit 949198d into netdata:master Aug 22, 2025
105 checks passed
@ilyam8 ilyam8 deleted the go.d-vnode-internal-metric-charts branch August 22, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/collectors Everything related to data collection area/go collectors/go.d
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants